-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Principal Access Boundary Admin to pab service account #12072
add Principal Access Boundary Admin to pab service account #12072
Conversation
…r to pab service account
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…l necessary perms.
@derekchu-google was there someone specific from the Terraform team that was helping you with this or directed you to add this? |
Sam Levenick pointed me to this file to add the missing permissions needed to test a new resource. see #12044 where the tests were failing due to insufficient perms |
/gcbrun |
I see, thank you for the context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the admin role to our 3 test service accounts manually
Release Note Template for Downstream PRs (will be copied)