Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Principal Access Boundary Admin to pab service account #12072

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

derekchu-google
Copy link
Contributor

@derekchu-google derekchu-google commented Oct 21, 2024

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from c2thorn October 21, 2024 20:45
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn
Copy link
Member

c2thorn commented Oct 21, 2024

@derekchu-google was there someone specific from the Terraform team that was helping you with this or directed you to add this?

@derekchu-google
Copy link
Contributor Author

@derekchu-google was there someone specific from the Terraform team that was helping you with this or directed you to add this?

Sam Levenick pointed me to this file to add the missing permissions needed to test a new resource. see #12044 where the tests were failing due to insufficient perms

@c2thorn
Copy link
Member

c2thorn commented Oct 21, 2024

/gcbrun

@c2thorn
Copy link
Member

c2thorn commented Oct 21, 2024

Sam Levenick pointed me to this file to add the missing permissions needed to test a new resource. see #12044 where the tests were failing due to insufficient perms

I see, thank you for the context

@derekchu-google derekchu-google changed the title add Principal Access Boundary Admin and Principal Access Boundary User to pab service account add Principal Access Boundary Admin to pab service account Oct 21, 2024
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the admin role to our 3 test service accounts manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants