Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add oracledatabase_autonomous_database datasource #12016

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

tulika-aakriti
Copy link
Contributor

Part of - hashicorp/terraform-provider-google#19851

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_autonomous_database`

@github-actions github-actions bot requested a review from rileykarson October 16, 2024 09:11
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 119 insertions(+))
google-beta provider: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 118 insertions(+))
google-beta provider: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 118 insertions(+))
google-beta provider: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What template or existing datasource did you reference? I think we need to restructure this a bit to account for hashicorp/terraform-provider-google#12873 (and also correct the source used here, so we don't proliferate more variations that aren't consistent with our intended behaviour)

@github-actions github-actions bot requested a review from rileykarson October 17, 2024 05:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 123 insertions(+))
google-beta provider: Diff ( 4 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 12
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@rileykarson
Copy link
Member

Merging is blocked temporarily- if I don't merge this by EOD today please feel free to ping me

@tulika-aakriti
Copy link
Contributor Author

What template or existing datasource did you reference? I think we need to restructure this a bit to account for hashicorp/terraform-provider-google#12873 (and also correct the source used here, so we don't proliferate more variations that aren't consistent with our intended behaviour)

I can't remember that but I can mostly all list API i.e datasources have similar thing.

@github-actions github-actions bot requested a review from rileykarson October 17, 2024 18:01
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
@tulika-aakriti tulika-aakriti deleted the datasource_adb branch October 21, 2024 05:34
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants