-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add oracledatabase_autonomous_database datasource #12016
Feat add oracledatabase_autonomous_database datasource #12016
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 11 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 11 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 11 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What template or existing datasource did you reference? I think we need to restructure this a bit to account for hashicorp/terraform-provider-google#12873 (and also correct the source used here, so we don't proliferate more variations that aren't consistent with our intended behaviour)
...d_party/terraform/services/oracledatabase/data_source_oracle_database_autonomous_database.go
Show resolved
Hide resolved
...d_party/terraform/services/oracledatabase/data_source_oracle_database_autonomous_database.go
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Merging is blocked temporarily- if I don't merge this by EOD today please feel free to ping me |
I can't remember that but I can mostly all list API i.e datasources have similar thing. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
…atform#12016) Co-authored-by: Riley Karson <[email protected]>
Part of - hashicorp/terraform-provider-google#19851
Release Note Template for Downstream PRs (will be copied)