Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add google_oracle_database_cloud_exadata_infrastructures datasource #12000

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Feat: Add google_oracle_database_cloud_exadata_infrastructures datasource #12000

merged 4 commits into from
Oct 16, 2024

Conversation

tulika-aakriti
Copy link
Contributor

datasource

Part of- hashicorp/terraform-provider-google#19849

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_cloud_exadata_infrastructures`

@tulika-aakriti tulika-aakriti changed the title Feat: Add google_oracle_database_cloud_exadata_infrastructures Feat: Add google_oracle_database_cloud_exadata_infrastructures datasource Oct 15, 2024
@github-actions github-actions bot requested a review from hao-nan-li October 15, 2024 08:03
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 190 insertions(+))
google-beta provider: Diff ( 4 files changed, 190 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@tulika-aakriti
Copy link
Contributor Author

/gcbrun

@tulika-aakriti
Copy link
Contributor Author

VCR tests failed as the tests were parallely running in other PR.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 190 insertions(+))
google-beta provider: Diff ( 4 files changed, 190 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

hao-nan-li
hao-nan-li reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's also a git conflict to resolve.

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl
@@ -169,6 +169,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
"google_monitoring_uptime_check_ips": monitoring.DataSourceGoogleMonitoringUptimeCheckIps(),
"google_netblock_ip_ranges": resourcemanager.DataSourceGoogleNetblockIpRanges(),
"google_oracle_database_db_servers": oracledatabase.DataSourceOracleDatabaseDbServers(),
"google_oracle_database_cloud_exadata_infrastructures": oracledatabase.DataSourceOracleDatabaseCloudExadataInfrastructures(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference of google_oracle_database_cloud_exadata_infrastructures and google_oracle_database_cloud_exadata_infrastructure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for get and list API separately.

...rraform/services/oracledatabase/data_source_oracle_database_cloud_exadata_infrastructures.go
Required: true,
Description: "location",
},
"cloud_exadata_infrastructures": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we possibly add this field to the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added to check if not null values are set, We can not add to check for all cloud_exadata_infrastructure instances because it might fail considering the list operation may list any resource that is still getting provisioned by other resource (cloud_exadata_infrastructures ) test

@github-actions github-actions bot requested a review from hao-nan-li October 16, 2024 07:26
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 191 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 191 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 196 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 196 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li merged commit a38017e into GoogleCloudPlatform:main Oct 16, 2024
11 checks passed
This was referenced Oct 16, 2024
Merged
Merged
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
@tulika-aakriti @gontech
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
542fc8e 
…urce (GoogleCloudPlatform#12000)
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
@tulika-aakriti @varshatumburu
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
6f1c2ac 
…urce (GoogleCloudPlatform#12000)
@tulika-aakriti tulika-aakriti deleted the datasource_exadatas branch October 21, 2024 05:34
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
@tulika-aakriti @BBBmau
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
cefe37b 
…urce (GoogleCloudPlatform#12000)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
@tulika-aakriti @BBBmau
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
fa19c12 
…urce (GoogleCloudPlatform#12000)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
@tulika-aakriti @BBBmau
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
32a797a 
…urce (GoogleCloudPlatform#12000)
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
@tulika-aakriti @akshat-jindal-nit
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
c33346c 
…urce (GoogleCloudPlatform#12000)
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@tulika-aakriti @amanMahendroo
Feat: Add google_oracle_database_cloud_exadata_infrastructures dataso…
aa136c8 
…urce (GoogleCloudPlatform#12000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hao-nan-li hao-nan-li hao-nan-li approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tulika-aakriti @modular-magician @hao-nan-li