-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import for google_essential_contacts_contact #11995
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 2 Click here to see the affected service packages
🟢 All tests passed! View the build log |
google_essential_contacts_contact
google_essential_contacts_contact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that uses this import format?
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 2 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 2 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Updated the tests to not ignore the parent attribute while verifying import state. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 2 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
…#11995) Co-authored-by: Tripti Tewari <[email protected]>
Fixes hashicorp/terraform-provider-google#11124
Added custom import to include required parent attribute when contact is imported. Argument ref for essential contacts.
Release Note Template for Downstream PRs (will be copied)