Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for google_essential_contacts_contact #11995

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

ttewari
Copy link
Contributor

@ttewari ttewari commented Oct 15, 2024

Fixes hashicorp/terraform-provider-google#11124

Added custom import to include required parent attribute when contact is imported. Argument ref for essential contacts.

Release Note Template for Downstream PRs (will be copied)

essentialcontacts: fixed `google_essential_contacts_contact` import to include required parent field.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • essentialcontacts

🟢 All tests passed!

View the build log

@ttewari ttewari changed the title Fixes https://github.com/hashicorp/terraform-provider-google/issues/11124 Fix import for google_essential_contacts_contact Oct 15, 2024
@ttewari ttewari changed the title Fix import for google_essential_contacts_contact Fix import for google_essential_contacts_contact Oct 15, 2024
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that uses this import format?

@github-actions github-actions bot requested a review from slevenick October 16, 2024 09:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 13 insertions(+), 8 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 13 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • essentialcontacts

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • essentialcontacts

🟢 All tests passed!

View the build log

@ttewari
Copy link
Contributor Author

ttewari commented Oct 16, 2024

Can you add a test that uses this import format?

Updated the tests to not ignore the parent attribute while verifying import state.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 13 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 2 files changed, 13 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 2
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • essentialcontacts

🟢 All tests passed!

View the build log

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick merged commit 9c0bb5a into GoogleCloudPlatform:main Oct 16, 2024
13 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_essential_contacts_contact import does not include required field parent
4 participants