Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add google_oracle_database_db_nodes datasource #11988

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Feat: Add google_oracle_database_db_nodes datasource #11988

merged 6 commits into from
Oct 15, 2024

Conversation

tulika-aakriti
Copy link
Contributor

Fix: hashicorp/terraform-provider-google#19787

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_db_nodes`

@github-actions github-actions bot requested a review from melinath October 11, 2024 18:11
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 326 insertions(+))
google-beta provider: Diff ( 4 files changed, 326 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 3
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseDbNodes_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseDbNodes_basic[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 327 insertions(+))
google-beta provider: Diff ( 4 files changed, 327 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 327 insertions(+))
google-beta provider: Diff ( 4 files changed, 327 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@tulika-aakriti
Copy link
Contributor Author

Hi Stephen, Please review the PR.
Thanks

melinath
melinath requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty straightforward; left a couple minor comments and questions below.

mmv1/third_party/terraform/services/oracledatabase/data_source_oracle_database_db_nodes_test.go Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from melinath October 15, 2024 17:50
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 330 insertions(+))
google-beta provider: Diff ( 4 files changed, 330 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 330 insertions(+))
google-beta provider: Diff ( 4 files changed, 330 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

melinath
melinath requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more changes based on checking against the API docs.

mmv1/third_party/terraform/services/oracledatabase/data_source_oracle_database_db_nodes.go Outdated Show resolved Hide resolved
mmv1/third_party/terraform/services/oracledatabase/data_source_oracle_database_db_nodes.go Outdated Show resolved Hide resolved
mmv1/third_party/terraform/services/oracledatabase/data_source_oracle_database_db_nodes.go Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/d/oracle_database_db_nodes.html.markdown Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from melinath October 15, 2024 22:46
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 332 insertions(+))
google-beta provider: Diff ( 4 files changed, 332 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 10
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@melinath melinath merged commit 4cabc2c into GoogleCloudPlatform:main Oct 15, 2024
10 checks passed
This was referenced Oct 15, 2024
Merged
Merged
@modular-magician modular-magician mentioned this pull request Oct 15, 2024
Merged
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
@tulika-aakriti @melinath @gontech
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
d7fa61c 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
@tulika-aakriti @melinath @varshatumburu
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
0dff73e 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
@tulika-aakriti @melinath @BBBmau
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
656cc57 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
@tulika-aakriti @melinath @BBBmau
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
00d0442 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
@tulika-aakriti @melinath @BBBmau
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
c55a357 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@tulika-aakriti tulika-aakriti deleted the feature/data_source_oracle_database_db_nodes branch November 11, 2024 16:40
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
@tulika-aakriti @melinath @akshat-jindal-nit
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
6da3c91 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@tulika-aakriti @melinath @amanMahendroo
Feat: Add google_oracle_database_db_nodes datasource (GoogleCloudPlat…
2b88cad 
…form#11988)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datasource for oracledatabase dbNodes
3 participants
@tulika-aakriti @modular-magician @melinath