Add creation_timestamp field to google_compute_instance and template resources

[karolgorc]

closes hashicorp/terraform-provider-google#15663

• added field creation_timestamp to
  • google_compute_instance
  • google_compute_instance_template
  • google_compute_region_instance_template
• added data source support (templates didn't need a change because they use the Read function from the resource)
• added doc changes

This is an output only field. Please LMK if you want it tested somehow.

Release Note Template for Downstream PRs (will be copied)

compute: added `creation_timestamp` field to `google_compute_instance`, `google_compute_instance_template`, `google_compute_region_instance_template`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 44 insertions(+))
google-beta provider: Diff ( 10 files changed, 44 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1026
Passed tests: 952
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[hao-nan-li]

Could you add this field to an existing test? Thanks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 47 insertions(+))
google-beta provider: Diff ( 13 files changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1028
Passed tests: 954
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[hao-nan-li]

I'm not sure if this field is tested. Add it to any existing test should be fine.

[karolgorc]

It's an output only field. You cannot do anything else than read it. Which is done here

resource.TestCheckResourceAttrSet("google_compute_instance_template.foobar", "creation_timestamp"),

I cannot really put a creation_timestamp = X in the test because it's Computed: true only. Same as self_link, etc. All we want to check basically is if it's set on instance creation because it cannot do anything else than take a value returned by the API

[github-actions]

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.