Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto_accept_projects in ncc group #11828

Merged
merged 30 commits into from
Oct 17, 2024

Conversation

prauc
Copy link
Contributor

@prauc prauc commented Sep 26, 2024

I messed up my other PR .. sorry for that..
This PR adds google_network_connectivity_group to define auto_accept_projects in NCC.

https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/v1/projects.locations.global.hubs.groups

Tests for networkconnectivity were already successfully executed locally

Release Note Template for Downstream PRs (will be copied)

`google_network_connectivity_group`

@prauc prauc changed the title Ncc autoaccept projects add auto_accept_projects in ncc group Sep 26, 2024
@github-actions github-actions bot requested a review from zli82016 September 26, 2024 09:43
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1170 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1170 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_group (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_group" "primary" {
  description = # value needed
  labels      = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 23
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityGroup_BasicGroup
  • TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_BasicGroup[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1134 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1134 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_group (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_group" "primary" {
  description = # value needed
  labels      = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Outdated Show resolved Hide resolved
mmv1/products/networkconnectivity/Group.yaml Show resolved Hide resolved
Co-authored-by: Zhenhua Li <[email protected]>
@github-actions github-actions bot requested a review from zli82016 October 4, 2024 10:58
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 24
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityGroup_BasicGroup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkConnectivityGroup_BasicGroup[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1011 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1011 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 23
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityGroup_BasicGroup
  • TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityGroup_BasicGroup[Debug log]
TestAccNetworkConnectivityGroup_networkConnectivityGroupBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from zli82016 October 17, 2024 15:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 997 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 997 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityGroup_BasicGroup

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityGroup_BasicGroup[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from zli82016 October 17, 2024 19:07
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 994 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 994 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 123 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

🟢 All tests passed!

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zli82016 zli82016 merged commit 1d989ef into GoogleCloudPlatform:main Oct 17, 2024
13 checks passed
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants