Change update method for `boot_disk.auto_delete` on `google_compute_instance` #11742

karolgorc · 2024-09-18T09:49:52Z

closes hashicorp/terraform-provider-google#14707
closes hashicorp/terraform-provider-google#6892

This will prevent recreating the VM when changing auto_delete parameter

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_instance` is no longer recreated when changing `boot_disk.auto_delete`

github-actions · 2024-09-18T09:50:28Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2024-09-23T09:42:02Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn · 2024-09-24T18:26:11Z

Hi @karolgorc,
I've found that you have many open pull requests for Magic Modules, and wanted to reach you about the upcoming language migration. I've randomly picked this pull request to comment on.

You can view the details of the language migration here: hashicorp/terraform-provider-google#19583

Later this week many of your pull requests may become incompatible due to the template files changing from Ruby (.erb) to Go (.tmpl) templates. Our team (Magic Modules repository maintainers) has some tooling to automatically convert changes to the new language, and we can prepare a converted commit for all of your open pull requests.

However, this converted commit will be rebased to a commit after the migration. This means in order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event anything went wrong or needs additional changes.

Of course, you also have the option to convert your pull requests yourself after the migration tomorrow. We have links to a preview branch and updated documentation in the link above.

As an owner of many open pull requests, what would you like to do? Do we have your permission to push commits to your fork's branches, or would you like to convert them yourself?

Let me know if you have any questions or if there is a better method to converse.

github-actions · 2024-09-25T09:41:57Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn · 2024-09-25T19:52:45Z

@karolgorc please see this comment: #11742 (comment)

If you would like assistance converting files, we need your permission to push changes to this branch.

karolgorc · 2024-09-26T07:18:56Z

Hi @c2thorn.

Thanks for the info. I see that the changes are already live. The branches affected are

auto-delete-update
resource-policies-diff
key-revocation-action-field
min-cpu-platform-error-message
remove-hardcoded-values-instance-template

You can force-push to the fork. Do you need me to do something in order for this to work?

c2thorn · 2024-09-26T13:46:12Z

Hi @c2thorn.

Thanks for the info. I see that the changes are already live. The branches affected are

auto-delete-update

resource-policies-diff

key-revocation-action-field

min-cpu-platform-error-message

remove-hardcoded-values-instance-template

You can force-push to the fork. Do you need me to do something in order for this to work?

Thanks @karolgorc!
If things go smoothly, you won't have to do anything. But to help in the case we need to restore your branch from our backups, could you add me (c2thorn) as collaborator to your fork here:
https://github.com/karolgorc/magic-modules/settings

karolgorc · 2024-09-27T06:04:39Z

done

change update method of auto_delete field

github-actions · 2024-10-02T09:41:46Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-09T09:40:57Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-16T09:42:15Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

KevsAlex · 2024-10-17T19:00:57Z

is this still in review or was it solved in some version ?

mmv1/third_party/terraform/services/compute/resource_compute_instance.go.tmpl

…nstance.go.tmpl Co-authored-by: Riley Karson <[email protected]>

github-actions · 2024-10-22T09:42:17Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-24T09:42:10Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-31T09:42:13Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

nightpool · 2024-11-01T16:22:33Z

Would love to see this get merged!

github-actions · 2024-11-07T09:41:42Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-11-14T09:42:20Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

karolgorc · 2024-11-15T09:17:22Z

Hi can this get reviewed or reassigned?

github-actions · 2024-11-21T09:42:59Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-11-28T09:43:14Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

rileykarson · 2024-12-02T20:20:03Z

Reassigning to @slevenick

Also /gcbrun

modular-magician · 2024-12-02T20:54:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 93 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 93 insertions(+), 13 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  boot_disk {
    auto_delete = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  boot_disk {
    auto_delete = # value needed
  }
}

modular-magician · 2024-12-02T21:12:48Z

Tests analytics

Total tests: 1070
Passed tests: 996
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstance_autoDeleteUpdate

Get to know how VCR tests work

modular-magician · 2024-12-02T21:15:17Z

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_autoDeleteUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…nstance` (GoogleCloudPlatform#11742) Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: Riley Karson <[email protected]>

github-actions bot requested a review from rileykarson September 18, 2024 09:50

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 18, 2024

c2thorn added the not-go-migrated label Sep 24, 2024

This was referenced Sep 25, 2024

Fix permadiff on boot_disk.initialize_params.resource_policies #11753

Merged

Add separate error message for not supported operation on min_cpu_platform #11289

Open

c2thorn mentioned this pull request Sep 25, 2024

Remove hardcoded values that are handled by the API #11423

Open

Convert from Ruby to Go

0ab6935

change update method of auto_delete field

c2thorn force-pushed the auto-delete-update branch from 144cf03 to 0ab6935 Compare September 27, 2024 20:00

c2thorn removed the not-go-migrated label Sep 27, 2024

rileykarson reviewed Oct 17, 2024

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_instance.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/compute/resource_compute_instance.go.tmpl Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/compute/resource_compute_i…

b309f14

…nstance.go.tmpl Co-authored-by: Riley Karson <[email protected]>

github-actions bot requested a review from rileykarson October 18, 2024 06:22

karolgorc added 2 commits October 18, 2024 09:50

change wrapf to errorf

44a622a

Merge branch 'main' into auto-delete-update

17cfcd9

rileykarson requested review from a team and slevenick and removed request for rileykarson and a team December 2, 2024 20:19

modular-magician added service/compute-instances and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 2, 2024

slevenick approved these changes Dec 4, 2024

View reviewed changes

slevenick merged commit 7ce8ed7 into GoogleCloudPlatform:main Dec 4, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change update method for `boot_disk.auto_delete` on `google_compute_instance` #11742

Change update method for `boot_disk.auto_delete` on `google_compute_instance` #11742

karolgorc commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 23, 2024

c2thorn commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024

c2thorn commented Sep 25, 2024

karolgorc commented Sep 26, 2024 •

edited

Loading

c2thorn commented Sep 26, 2024

karolgorc commented Sep 27, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 16, 2024

KevsAlex commented Oct 17, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 31, 2024

nightpool commented Nov 1, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 14, 2024

karolgorc commented Nov 15, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 28, 2024

rileykarson commented Dec 2, 2024

modular-magician commented Dec 2, 2024

modular-magician commented Dec 2, 2024

modular-magician commented Dec 2, 2024

Change update method for boot_disk.auto_delete on google_compute_instance #11742

Change update method for boot_disk.auto_delete on google_compute_instance #11742

Conversation

karolgorc commented Sep 18, 2024 • edited Loading

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 23, 2024

c2thorn commented Sep 24, 2024 • edited Loading

github-actions bot commented Sep 25, 2024

c2thorn commented Sep 25, 2024

karolgorc commented Sep 26, 2024 • edited Loading

c2thorn commented Sep 26, 2024

karolgorc commented Sep 27, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 16, 2024

KevsAlex commented Oct 17, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 31, 2024

nightpool commented Nov 1, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 14, 2024

karolgorc commented Nov 15, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 28, 2024

rileykarson commented Dec 2, 2024

modular-magician commented Dec 2, 2024

Diff report

Missing test report

modular-magician commented Dec 2, 2024

Tests analytics

Action taken

modular-magician commented Dec 2, 2024

Change update method for `boot_disk.auto_delete` on `google_compute_instance` #11742

Change update method for `boot_disk.auto_delete` on `google_compute_instance` #11742

karolgorc commented Sep 18, 2024 •

edited

Loading

c2thorn commented Sep 24, 2024 •

edited

Loading

karolgorc commented Sep 26, 2024 •

edited

Loading