-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google_site_verification_owner resource #11716
Add google_site_verification_owner resource #11716
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_site_verification_owner" "primary" {
email = # value needed
web_resource_id = # value needed
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_site_verification_owner" "primary" {
email = # value needed
web_resource_id = # value needed
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_site_verification_owner" "primary" {
email = # value needed
web_resource_id = # value needed
}
|
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_site_verification_owner" "primary" {
email = # value needed
web_resource_id = # value needed
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
View the build log |
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
Fix some missed test auth scope additions Fix google_bigquery_tables, which somehow was inadvertently deleted Touch up docs Add documentation Update docs a bit Add initial google_site_verification_owner resource
615aec8
to
2fdf689
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_site_verification_owner" "primary" {
email = # value needed
web_resource_id = # value needed
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
This is the third and final (hopefully) PR implementing issue 5698. The first two were #10999 and #11624.
google_site_verification_owner
is a fine grained resource on theowners
field ofgoogle_site_verification_web_resource
. That field is a little funky: it's automatically populated with every user that has verified ownership and every user that verified owners have optionally added. What makes it particularly funky is that multiple users can independently verify ownership, for example:[email protected]
verifieswww.example.com
, theowners
field will contain["[email protected]"]
[email protected]
verifieswww.example.com
, theowners
field now contains["[email protected]", "[email protected]"]
[email protected]
as an owner, theowners
field now contains["[email protected]", "[email protected]", "[email protected]"]
Verified owners aren't explicitly configured either; they're implicitly added based on the authenticated identity of the user requesting verification.
There's more info about the resource in the included markdown doc.
Release Note Template for Downstream PRs (will be copied)