Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_site_verification_owner resource #11716

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

SirGitsalot
Copy link
Member

This is the third and final (hopefully) PR implementing issue 5698. The first two were #10999 and #11624.

google_site_verification_owner is a fine grained resource on the owners field of google_site_verification_web_resource. That field is a little funky: it's automatically populated with every user that has verified ownership and every user that verified owners have optionally added. What makes it particularly funky is that multiple users can independently verify ownership, for example:

  1. [email protected] verifies www.example.com, the owners field will contain ["[email protected]"]
  2. Separately, [email protected] verifies www.example.com, the owners field now contains ["[email protected]", "[email protected]"]
  3. One of the previous verified owners adds [email protected] as an owner, the owners field now contains ["[email protected]", "[email protected]", "[email protected]"]

Verified owners aren't explicitly configured either; they're implicitly added based on the authenticated identity of the user requesting verification.

There's more info about the resource in the included markdown doc.

Release Note Template for Downstream PRs (will be copied)

`google_site_verification_owner`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 706 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 706 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_site_verification_owner (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_site_verification_owner" "primary" {
  email           = # value needed
  web_resource_id = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 706 insertions(+))
google-beta provider: Diff ( 4 files changed, 706 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_site_verification_owner (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_site_verification_owner" "primary" {
  email           = # value needed
  web_resource_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • siteverification

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSiteVerificationOwner_siteVerificationBucket

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • siteverification

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSiteVerificationOwner_siteVerificationBucket

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 706 insertions(+))
google-beta provider: Diff ( 4 files changed, 706 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_site_verification_owner (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_site_verification_owner" "primary" {
  email           = # value needed
  web_resource_id = # value needed
}

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSiteVerificationOwner_siteVerificationBucket[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSiteVerificationOwner_siteVerificationBucket[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccSiteVerificationOwner_siteVerificationBucket[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • siteverification

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSiteVerificationOwner_siteVerificationBucket

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSiteVerificationOwner_siteVerificationBucket[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 709 insertions(+))
google-beta provider: Diff ( 4 files changed, 709 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_site_verification_owner (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_site_verification_owner" "primary" {
  email           = # value needed
  web_resource_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • siteverification

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@rileykarson rileykarson requested review from a team and trodge and removed request for rileykarson and a team September 24, 2024 22:12
Fix some missed test auth scope additions
Fix google_bigquery_tables, which somehow was inadvertently deleted
Touch up docs
Add documentation
Update docs a bit
Add initial google_site_verification_owner resource
@trodge trodge force-pushed the siteverification-owner branch from 615aec8 to 2fdf689 Compare September 25, 2024 22:25
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 709 insertions(+))
google-beta provider: Diff ( 4 files changed, 709 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_site_verification_owner (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_site_verification_owner" "primary" {
  email           = # value needed
  web_resource_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • siteverification

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSiteVerificationOwner_siteVerificationBucket

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSiteVerificationOwner_siteVerificationBucket[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@SirGitsalot SirGitsalot deleted the siteverification-owner branch September 26, 2024 18:10
sebkalis pushed a commit to sebkalis/magic-modules that referenced this pull request Sep 27, 2024
anavada pushed a commit to anavada/magic-modules that referenced this pull request Sep 30, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge added a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants