Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for Config Sync auto-upgrades into google_gkehub_feature_membership resource doc #11684

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

haiyanmeng
Copy link
Contributor

@haiyanmeng haiyanmeng commented Sep 11, 2024

Add an example for Config Sync auto-upgrades into the google_gkehub_feature_membership resource doc

This PR also moves all the examples for the configmanagement feature next to each other.

Release Note Template for Downstream PRs (will be copied)

docs: added an example for Config Sync auto-upgrades into `google_gkehub_feature_membership` resource

google_gkehub_feature_membership resource

This PR also moves all the examples for the configmanagement feature
next to each other.
@github-actions github-actions bot requested a review from zli82016 September 11, 2024 17:46
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 77 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 1 file changed, 77 insertions(+), 28 deletions(-))

@zli82016 zli82016 changed the title Add an example for Config Sync auto-upgrades into the google_gkehub_feature_membership resource Add an example for Config Sync auto-upgrades into google_gkehub_feature_membership resource doc Sep 13, 2024
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zli82016 zli82016 merged commit 05927dc into GoogleCloudPlatform:main Sep 13, 2024
12 checks passed
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants