Redis Cluster maintenance policy and schedule addition

[harshitpatel-github]

Release Note Template for Downstream PRs (will be copied)

redis: added the `maintenance_policy` field to the `google_redis_cluster` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 634 insertions(+))
google-beta provider: Diff ( 4 files changed, 678 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 163 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  maintenance_policy {
    description = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 15
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• redis

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType
• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_redisClusterHaSingleZoneExample
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 634 insertions(+))
google-beta provider: Diff ( 4 files changed, 678 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 163 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  maintenance_policy {
    description = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 19
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• redis

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_redisClusterHaSingleZoneExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 634 insertions(+))
google-beta provider: Diff ( 4 files changed, 678 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 163 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  maintenance_policy {
    description = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 15
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• redis

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType
• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_redisClusterHaSingleZoneExample
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Debug log]
TestAccRedisCluster_updateRedisConfigs[Debug log]
TestAccRedisCluster_updateReplicaCount[Debug log]
TestAccRedisCluster_updateShardCount[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 638 insertions(+))
google-beta provider: Diff ( 4 files changed, 683 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 163 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 24 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 15
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• redis

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType
• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_redisClusterHaSingleZoneExample
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 638 insertions(+))
google-beta provider: Diff ( 4 files changed, 683 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 163 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 24 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 15
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

• redis

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType
• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_redisClusterHaSingleZoneExample
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 604 insertions(+))
google-beta provider: Diff ( 4 files changed, 649 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 16
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• redis

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType
• TestAccRedisCluster_redisClusterHaExample
• TestAccRedisCluster_updateRedisConfigs
• TestAccRedisCluster_updateReplicaCount
• TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_redisClusterHaExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 604 insertions(+))
google-beta provider: Diff ( 4 files changed, 648 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 21
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• redis

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[SarahFrench]

Hi, thanks for your PR!

It looks like this is adding support for a new feature that's about to be released, as the public docs don't include these fields. I've reviewed the PR the best I can given this, and there are only some minor comments. Happy to merge after they're addressed.

[SarahFrench]

Suggested change

- DAY_OF_WEEK_UNSPECIFIED: The day of the week is unspecified.

We usually omit these values from enums, as they aren't valid for users to supply

[harshitpatel-github]

We have taken reference from

magic-modules/mmv1/products/redis/Instance.yaml

Line 316 in 692bae2

- DAY_OF_WEEK_UNSPECIFIED: The day of the week is unspecified.

and want to keep the Cluster changes similar to Redis Instance.
Is this fine? or should I remove this from the Cluster.yaml

[SarahFrench]

Suggested change

- :DAY_OF_WEEK_UNSPECIFIED

See other comment!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 602 insertions(+))
google-beta provider: Diff ( 4 files changed, 646 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_createClusterWithNodeType

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 604 insertions(+))
google-beta provider: Diff ( 4 files changed, 648 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 21
Passed tests: 21
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• redis

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[SarahFrench]

Looks good to me - thanks for the updates!