Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceRefs for Compute Route. #1157

Merged

Conversation

rileykarson
Copy link
Member

We were failing some tests due to self link stability, turns out the resources weren't ResourceRefs because some old TODOs weren't completed.

Remove the reference to Gateway being added to MM because to my best knowledge that is not a GCP resource- only default-internet-gateway can be configured.


[all]

[terraform]

Fix self link stability issues in google_compute_route

[terraform-beta]

[ansible]

[inspec]

@rileykarson
Copy link
Member Author

@ndmckinley for general review + @rambleraptor for Ansible

@nat-henderson
Copy link
Contributor

LGTM + tf downstreams

@rileykarson
Copy link
Member Author

Historical Reference: I had to do a rebase/force push because #1123 made one of the changes but not the other and made that change in a slightly different way (I rearranged the input variable to be above description).

I'd merged my downstreams, then #1123's downstreams + upstream were merged before my upstream was merged. There should be no or minimal downstream changes.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#316
depends: hashicorp/terraform-provider-google#2805
depends: modular-magician/inspec-gcp#52

@rileykarson
Copy link
Member Author

rileykarson commented Jan 4, 2019

Closing out all the downstreams and merging, we suspect they were all generated in a short window (~90s) where PRs aren't reconciled correctly.

@modular-magician modular-magician merged commit 05d3ead into GoogleCloudPlatform:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants