-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResourceRefs for Compute Route. #1157
Add ResourceRefs for Compute Route. #1157
Conversation
@ndmckinley for general review + @rambleraptor for Ansible |
LGTM + tf downstreams |
56d303d
to
724ba50
Compare
Historical Reference: I had to do a rebase/force push because #1123 made one of the changes but not the other and made that change in a slightly different way (I rearranged the I'd merged my downstreams, then #1123's downstreams + upstream were merged before my upstream was merged. There should be no or minimal downstream changes. |
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Closing out all the downstreams and merging, we suspect they were all generated in a short window (~90s) where PRs aren't reconciled correctly. |
724ba50
to
0a7b863
Compare
We were failing some tests due to self link stability, turns out the resources weren't ResourceRefs because some old TODOs weren't completed.
Remove the reference to
Gateway
being added to MM because to my best knowledge that is not a GCP resource- onlydefault-internet-gateway
can be configured.[all]
[terraform]
Fix self link stability issues in google_compute_route
[terraform-beta]
[ansible]
[inspec]