Promote Server Tls Policy to V1

[pawelJas]

Promote Server TLS Policy to V1

Also fixed hashicorp/terraform-provider-google#18103

Release Note Template for Downstream PRs (will be copied)

networksecurity: `google_network_security_server_tls_policy` (ga)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1417 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 31
Skipped tests: 5
Affected tests: 3

Click here to see the affected service packages

• networksecurity

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample[Error message] [Debug log]
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample[Error message] [Debug log]
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1408 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 24 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 9 deletions(-))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 33
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages

• networksecurity

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1401 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 38 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 16 deletions(-))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 34
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages

• networksecurity

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

Running tests in GA: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_NETWORKSECURITY/225929?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true

[melinath]

It looks like the tests all passed in GA, so I'll approve & merge when the tests finish running again.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1400 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 39 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 16 deletions(-))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 34
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

• networksecurity

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyAdvancedExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample
• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyServerCertExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test