-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google.golang.org/api to v0.193.0 #11520
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hello, we are currently frozen for 6.0 release. I will come back to this when we are no longer frozen. |
How long will you be frozen for? Is it until August 26th, 2024 when 6.0.0 release is published to end users? |
We are unfrozen now. Can you re-pull the latest changes from main ? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Done! |
Tests analyticsTotal tests: 3902 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3902 Click here to see the affected service packages
View the build log |
@ScottSuarez I noticed that some "terraform-google-conversion-build-and-unit-tests" tests were failing. I didn't change these unit tests, so I don't really understand why updating the API client would make these fail. |
@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@ScottSuarez Can you please approve the PR? The VCR tests should be fixed. So you should be able to trigger a rerun of them with: /gcbrun |
Update google.golang.org/api to v0.193.0 to support StoragePools NodeConfig field.
Release Note Template for Downstream PRs (will be copied)