Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google.golang.org/api to v0.193.0 #11520

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

amacaskill
Copy link
Contributor

Update google.golang.org/api to v0.193.0 to support StoragePools NodeConfig field.

Release Note Template for Downstream PRs (will be copied)

Update Google Go API dependency to v0.193.0

@github-actions github-actions bot requested a review from ScottSuarez August 21, 2024 21:11
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 21, 2024
@ScottSuarez
Copy link
Contributor

Hello, we are currently frozen for 6.0 release. I will come back to this when we are no longer frozen.

@amacaskill
Copy link
Contributor Author

Hello, we are currently frozen for 6.0 release. I will come back to this when we are no longer frozen.

How long will you be frozen for? Is it until August 26th, 2024 when 6.0.0 release is published to end users?

@ScottSuarez
Copy link
Contributor

We are unfrozen now. Can you re-pull the latest changes from main ?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 54 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 54 deletions(-))

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 22, 2024
@amacaskill
Copy link
Contributor Author

We are unfrozen now. Can you re-pull the latest changes from main ?

Done!

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3902
Passed tests: 3491
Skipped tests: 411
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 54 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 54 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3902
Passed tests: 3491
Skipped tests: 411
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@amacaskill
Copy link
Contributor Author

amacaskill commented Aug 23, 2024

@ScottSuarez I noticed that some "terraform-google-conversion-build-and-unit-tests" tests were failing. I didn't change these unit tests, so I don't really understand why updating the API client would make these fail.

Copy link

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@amacaskill
Copy link
Contributor Author

@ScottSuarez I noticed that some "terraform-google-conversion-build-and-unit-tests" tests were failing. I didn't change these unit tests, so I don't really understand why updating the API client would make these fail.

@ScottSuarez Can you please approve the PR? The VCR tests should be fixed. So you should be able to trigger a rerun of them with:

/gcbrun

@ScottSuarez ScottSuarez merged commit 6d8da0f into GoogleCloudPlatform:main Aug 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants