-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about acceptance tests #11475
docs: add note about acceptance tests #11475
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
85a9acd
to
799fb78
Compare
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
While it is probably obvious, it may be good to provide a reminder to people about acceptance tests, to make sure they understand to use a temporary / sandbox project, and to keep an eye out for stray resources. For folks outside of Google's ecosystem, this is probably particularly important, especially as some tests create resources that can generate significant costs.
799fb78
to
79b90ce
Compare
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Fixes note added in GoogleCloudPlatform#11475 to work within Hugo and match other notes
While it is probably obvious, it may be good to provide a reminder to people about acceptance tests, to make sure they understand to use a temporary / sandbox project, and to keep an eye out for stray resources (ask me how I was reminded about this sometime 🙃).
For folks outside of Google's ecosystem, this is probably particularly important, especially as some tests create resources that can generate significant costs.
(I assume the
NOTE
syntax shows up Ok under GH pages as well, but may be worth double checking; not sure if any of these docs specifically also show up under the tf registry, but assuming not?)Release Note Template for Downstream PRs (will be copied)