Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about acceptance tests #11475

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Aug 16, 2024

While it is probably obvious, it may be good to provide a reminder to people about acceptance tests, to make sure they understand to use a temporary / sandbox project, and to keep an eye out for stray resources (ask me how I was reminded about this sometime 🙃).

For folks outside of Google's ecosystem, this is probably particularly important, especially as some tests create resources that can generate significant costs.

(I assume the NOTE syntax shows up Ok under GH pages as well, but may be worth double checking; not sure if any of these docs specifically also show up under the tf registry, but assuming not?)

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from c2thorn August 16, 2024 21:54
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 16, 2024
Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@wyardley wyardley force-pushed the wyardley/docs/acceptance branch 3 times, most recently from 85a9acd to 799fb78 Compare August 22, 2024 22:20
Copy link

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

While it is probably obvious, it may be good to provide a reminder to
people about acceptance tests, to make sure they understand to use a
temporary / sandbox project, and to keep an eye out for stray resources.

For folks outside of Google's ecosystem, this is probably particularly
important, especially as some tests create resources that can generate
significant costs.
@wyardley wyardley force-pushed the wyardley/docs/acceptance branch from 799fb78 to 79b90ce Compare August 26, 2024 20:54
Copy link

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn self-requested a review August 30, 2024 17:13
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 30, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn merged commit eee25d3 into GoogleCloudPlatform:main Aug 30, 2024
10 of 11 checks passed
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
@wyardley wyardley deleted the wyardley/docs/acceptance branch September 25, 2024 19:23
wyardley added a commit to wyardley/magic-modules that referenced this pull request Oct 16, 2024
Fixes note added in GoogleCloudPlatform#11475 to work within Hugo and match other notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants