Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to 1.71.0 #11402

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Upgrade DCL to 1.71.0 #11402

merged 3 commits into from
Aug 12, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Aug 8, 2024

Release Note Template for Downstream PRs (will be copied)

clouddeploy: added `serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.pod_selector_label` and `serial_pipeline.stages.strategy.canary.runtime_config.kubernetes.service_networking.pod_selector_label` fields to `google_clouddeploy_delivery_pipeline` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 27 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 30 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_delivery_pipeline (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                pod_selector_label = # value needed
              }
            }
          }
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 27 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 38 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3891
Passed tests: 3506
Skipped tests: 384
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3891
Passed tests: 3504
Skipped tests: 384
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline
  • TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline
  • TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]
TestAccDNSRecordSet_routingPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and rileykarson and removed request for a team August 9, 2024 18:45
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 27 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 38 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3899
Passed tests: 3514
Skipped tests: 384
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDNSRecordSet_routingPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@zli82016 zli82016 merged commit 8bed26c into GoogleCloudPlatform:main Aug 12, 2024
12 checks passed
@zli82016 zli82016 deleted the dcl-1.71.0 branch August 12, 2024 16:20
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants