Apply new labels model to container cluster and edgenetwork resources #11320

zli82016 · 2024-08-01T04:30:44Z

Part of hashicorp/terraform-provider-google#16219

Apply new labels model to google_container_cluster, google_edgenetwork_network and google_edgenetwork_subnet

Release Note Template for Downstream PRs (will be copied)

container: three label-related fields are now in `google_container_cluster` resource. `resource_labels` field is non-authoritative and only manages the labels defined by the users on the resource through Terraform. The new output-only `terraform_labels` field merges the labels defined by the users on the resource through Terraform and the default labels configured on the provider. The new output-only `effective_labels` field lists all of labels present on the resource in GCP, including the labels configured through Terraform, the system, and other clients.

container: made three fields `resource_labels`, `terraform_labels`, and `effective_labels` be present in `google_container_cluster` datasources. All three fields will have all of labels present on the resource in GCP including the labels configured through Terraform, the system, and other clients, equivalent to `effective_labels` on the resource.

edgenetwork: three label-related fields are now in `google_edgenetwork_network ` and `google_edgenetwork_subnet` resources. `labels` field is non-authoritative and only manages the labels defined by the users on the resource through Terraform. The new output-only `terraform_labels` field merges the labels defined by the users on the resource through Terraform and the default labels configured on the provider. The new output-only `effective_labels` field lists all of labels present on the resource in GCP, including the labels configured through Terraform, the system, and other clients.

modular-magician · 2024-08-01T04:42:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 426 insertions(+), 48 deletions(-))
google-beta provider: Diff ( 9 files changed, 426 insertions(+), 48 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

modular-magician · 2024-08-01T05:52:28Z

Tests analytics

Total tests: 3877
Passed tests: 3410
Skipped tests: 386
Affected tests: 81

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccContainerCluster_withProviderDefaultLabels

Action taken

Found 81 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate

TestAccComputeBackendService_trafficDirectorUpdateBasic

TestAccComputeBackendService_trafficDirectorUpdateFull

TestAccComputeBackendService_trafficDirectorUpdateLbPolicies

TestAccComputeForwardingRule_forwardingRuleExternallbExample

TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample

TestAccComputeForwardingRule_forwardingRuleHttpLbExample

TestAccComputeForwardingRule_forwardingRuleInternallbExample

TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example

TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6

TestAccComputeForwardingRule_forwardingRuleL3DefaultExample

TestAccComputeForwardingRule_forwardingRulePscRecreate

TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample

TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate

TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample

TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample

TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate

TestAccComputePacketMirroring_computePacketMirroringFullExample

TestAccComputeRegionBackendService_basic

TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol

TestAccComputeRegionBackendService_ilbUpdateBasic

TestAccComputeRegionBackendService_ilbUpdateFull

TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample

TestAccComputeRegionBackendService_regionBackendServiceCacheExample

TestAccComputeRegionBackendService_regionBackendServiceExternalExample

TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample

TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample

TestAccComputeRegionBackendService_subsettingUpdate

TestAccComputeRegionBackendService_withBackendAndIAP

TestAccComputeRegionBackendService_withBackendInternal

TestAccComputeRegionBackendService_withBackendInternalManaged

TestAccComputeRegionBackendService_withBackendMultiNic

TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate

TestAccComputeRegionBackendService_withSecurityPolicy

TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample

TestAccComputeRegionTargetHttpProxy_update

TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample

TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample

TestAccComputeRegionTargetHttpsProxy_update

TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample

TestAccComputeRegionTargetTcpProxy_update

TestAccComputeRegionUrlMap_advanced

TestAccComputeRegionUrlMap_defaultRouteAction_full_update

TestAccComputeRegionUrlMap_ilbPathUpdate

TestAccComputeRegionUrlMap_ilbRouteUpdate

TestAccComputeRegionUrlMap_noPathRulesWithUpdate

TestAccComputeRegionUrlMap_regionUrlMapBasicExample

TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample

TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample

TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample

TestAccComputeRegionUrlMap_update_path_matcher

TestAccComputeRoute_routeIlbExample

TestAccComputeRoute_routeIlbVipExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExample

TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample

TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample

TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample

TestAccDataSourceArtifactRegistryDockerImage

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-01T07:35:23Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionTargetHttpsProxy_addSslPolicy_withForwardingRule[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapPathTemplateMatchExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Error message] [Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Error message] [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Error message] [Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-01T19:10:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 438 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 11 files changed, 438 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

modular-magician · 2024-08-01T20:19:13Z

Tests analytics

Total tests: 3877
Passed tests: 3472
Skipped tests: 386
Affected tests: 19

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccContainerCluster_withProviderDefaultLabels

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate

TestAccComputeForwardingRule_forwardingRuleHttpLbExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExample

TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate

TestAccComputePacketMirroring_computePacketMirroringFullExample

TestAccComputeRegionBackendService_withBackendMultiNic

TestAccContainerClusterDatasource_regional

TestAccDataSourceArtifactRegistryDockerImage

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-01T20:47:43Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccContainerClusterDatasource_regional[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-01T21:10:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

modular-magician · 2024-08-01T22:18:42Z

Tests analytics

Total tests: 3877
Passed tests: 3480
Skipped tests: 386
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccContainerCluster_withProviderDefaultLabels

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccDataSourceArtifactRegistryDockerImage

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-01T22:37:11Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-06T00:36:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

modular-magician · 2024-08-06T00:39:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 11 files changed, 447 insertions(+), 49 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_edgenetwork_network (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_network" "primary" {
  labels = # value needed
}

Resource: google_edgenetwork_subnet (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_edgenetwork_subnet" "primary" {
  labels = # value needed
}

modular-magician · 2024-08-06T01:45:55Z

Tests analytics

Total tests: 3886
Passed tests: 3486
Skipped tests: 387
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccContainerCluster_withProviderDefaultLabels

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataformRepositoryIamPolicyGenerated

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoExample

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-06T01:47:19Z

Tests analytics

Total tests: 3886
Passed tests: 3486
Skipped tests: 387
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccContainerCluster_withProviderDefaultLabels

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataformRepositoryIamPolicyGenerated

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoExample

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-06T02:07:08Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataformRepositoryIamPolicyGenerated[Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-06T02:07:55Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccDataformRepositoryIamPolicyGenerated[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoExample[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-08-09T09:40:47Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician added service/container service/edgenetwork labels Aug 1, 2024

zli82016 added the override-breaking-change Allows a potential breaking change to be merged label Aug 1, 2024

zli82016 force-pushed the apply-labels-model-1 branch from f6e6d8f to 7811bc5 Compare August 1, 2024 20:59

zli82016 changed the title ~~Apply new labels model~~ Apply new labels model to google_container_cluster and edgenetwork resources Aug 1, 2024

zli82016 changed the title ~~Apply new labels model to google_container_cluster and edgenetwork resources~~ Apply new labels model to container cluster and edgenetwork resources Aug 1, 2024

zli82016 added 2 commits August 5, 2024 17:23

Apply new labels model

a9c7bb5

Set labels fields in data source

8356cc1

zli82016 force-pushed the apply-labels-model-1 branch from 7811bc5 to 91009b9 Compare August 6, 2024 00:23

Update 6.0 guide

0732dfa

zli82016 force-pushed the apply-labels-model-1 branch from 91009b9 to 0732dfa Compare August 6, 2024 00:26

zli82016 requested a review from rileykarson August 6, 2024 21:35

rileykarson approved these changes Aug 9, 2024

View reviewed changes

zli82016 merged commit 75ce1f6 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Aug 9, 2024
14 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply new labels model to container cluster and edgenetwork resources #11320

Apply new labels model to container cluster and edgenetwork resources #11320

zli82016 commented Aug 1, 2024 •

edited

Loading

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

github-actions bot commented Aug 9, 2024

Apply new labels model to container cluster and edgenetwork resources #11320

Apply new labels model to container cluster and edgenetwork resources #11320

Conversation

zli82016 commented Aug 1, 2024 • edited Loading

modular-magician commented Aug 1, 2024

Diff report

Missing test report

modular-magician commented Aug 1, 2024

Tests analytics

Action taken

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

Diff report

Missing test report

modular-magician commented Aug 1, 2024

Tests analytics

Action taken

modular-magician commented Aug 1, 2024

modular-magician commented Aug 1, 2024

Diff report

Missing test report

modular-magician commented Aug 1, 2024

Tests analytics

Action taken

modular-magician commented Aug 1, 2024

modular-magician commented Aug 6, 2024

Diff report

Missing test report

modular-magician commented Aug 6, 2024

Diff report

Missing test report

modular-magician commented Aug 6, 2024

Tests analytics

Action taken

modular-magician commented Aug 6, 2024

Tests analytics

Action taken

modular-magician commented Aug 6, 2024

modular-magician commented Aug 6, 2024

github-actions bot commented Aug 9, 2024

zli82016 commented Aug 1, 2024 •

edited

Loading