Initial addition of generated Image to Terraform. #1121
Conversation
nat-henderson
force-pushed
the
tf-image
branch
from
0470d13 to
df526b3
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 68563a1) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit c108a8a) have been included in your existing downstream PRs. |
| Providers: testAccProviders, | ||
| CheckDestroy: testAccCheckComputeImageDestroy, | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, |
There was a problem hiding this comment.
I think the CheckDestroy should still be in here.
Also while you're here, I think this test should be moved into resource_compute_image_test.go so we can keep all the hand-written acceptance tests in the same file.
There was a problem hiding this comment.
Done! In the meantime, fixed checkdestroy's tendency to check whether we had destroyed data sources with the same type name as the resource in question. :)
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 1d66634) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 9683913) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
tf-image
branch
from
e11c2a3 to
18e7026
Compare
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]