Enabling empty value send for fleet default member config in google_gke_hub_feature

[sahsagar-google]

Fixes hashicorp/terraform-provider-google#18441

Release Note Template for Downstream PRs (will be copied)

gkehub: allowed `google_gke_hub_feature` field to send empty values for its field `fleet_default_member_config`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 45 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 13
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• gkehub2

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[SarahFrench]

There's currently a failing test related to the terraform-google-conversion project - see here: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/9509187749/job/26211722803

        read_test.go:239: TestReadPlannedAssetsCoverage/example_gke_hub_feature diff(-want, +got):
              []caiasset.Asset{
              	{
              		Name: "//gkehub.googleapis.com/projects/foobar/locations/global/feature"...,
              		Type: "gkehub.googleapis.com/Feature",
              		Resource: &caiasset.AssetResource{
              			... // 2 identical fields
              			DiscoveryName: "Feature",
              			Parent:        "//cloudresourcemanager.googleapis.com/projects/foobar",
              			Data: map[string]any{
            + 				"fleetDefaultMemberConfig": nil,
              				"labels":                   map[string]any{"foo": string("bar")},
              			},
              		},
              		IAMPolicy: nil,
              		OrgPolicy: nil,
              		... // 2 identical fields
              	},
              }
FAIL

I think the resolution is to update tgc/tests/data/example_gke_hub_feature.json to add "fleetDefaultMemberConfig": null, - could you please try?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 45 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 13
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• gkehub2

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[sahsagar-google]

@SarahFrench I made the suggested changes. Are the tests passing now? Please let me know if anything else is required. Thank you again!

[github-actions]

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[SarahFrench]

LGTM, thanks for fixing that test!