Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go rewrite - copy script and adjustments for compute #10929

Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jun 10, 2024

Example commands for datafusion

  1. recreate go_*.yaml files in MMv1 directory with empty descriptons/notes
    bundle exec compiler -v "beta" -e terraform -o "$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta" -p products/datafusion --go-yaml
  2. run description-copy.go to insert exact text from ruby yaml
    go run . --yaml
  3. run go engine
    go run . --version beta --output $GOPATH/src/github.com/hashicorp/terraform-provider-google-beta

@c2thorn c2thorn changed the title copy script and adjustments for compute go rewrite - copy script and adjustments for compute Jun 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 956
Passed tests: 880
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested review from NickElliot June 11, 2024 17:18
@@ -0,0 +1,167 @@
# Copyright 2023 Google Inc.
Copy link
Member Author

@c2thorn c2thorn Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just renaming the old file VpnGateway.yaml, it does not affect generation, but affects the conversion script

@@ -50,26 +50,6 @@ parameters:
description: 'A reference to the zone where the instance group resides.'
required: true
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.erb'
- !ruby/object:Api::Type::Array
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A completely excluded field, removed to make the description script work easier

@@ -1,106 +0,0 @@
# Copyright 2023 Google Inc.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to VpnGateway.yaml

@@ -12,21 +12,17 @@
# limitations under the License.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments, this is really a renaming of files between HaVpnGateway and VpnGateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants