-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go rewrite - copy script and adjustments for compute #10929
go rewrite - copy script and adjustments for compute #10929
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy |
|
@@ -0,0 +1,167 @@ | |||
# Copyright 2023 Google Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just renaming the old file VpnGateway.yaml
, it does not affect generation, but affects the conversion script
@@ -50,26 +50,6 @@ parameters: | |||
description: 'A reference to the zone where the instance group resides.' | |||
required: true | |||
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.erb' | |||
- !ruby/object:Api::Type::Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A completely excluded field, removed to make the description script work easier
@@ -1,106 +0,0 @@ | |||
# Copyright 2023 Google Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to VpnGateway.yaml
@@ -12,21 +12,17 @@ | |||
# limitations under the License. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comments, this is really a renaming of files between HaVpnGateway
and VpnGateway
Example commands for datafusion
bundle exec compiler -v "beta" -e terraform -o "$GOPATH/src/github.com/hashicorp/terraform-provider-google-beta" -p products/datafusion --go-yaml
go run . --yaml
go run . --version beta --output $GOPATH/src/github.com/hashicorp/terraform-provider-google-beta