Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform] fix disk behaivor in compute_instance_from_template #1077

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#2122.

We use the instance expand code, which separates disks by type and merges them together into one list of disks. This meant that if a user tried to override an attached disk in the instance_from_template resource, it would try to override the boot disk as well. This fixes that bug, and also includes a fix where we were force-sending fields that weren't set, which meant that boolean fields that default to true and weren't overridden in the config were being overridden to false anyway.


[all]

[terraform]

fix disk behaivor in compute_instance_from_template

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#250
depends: hashicorp/terraform-provider-google#2695

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thought

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit fe6f402) have been included in your existing downstream PRs.

danawillow and others added 3 commits December 18, 2018 18:26
@modular-magician modular-magician force-pushed the tf-2122-instance-from-template branch from 75716c1 to 21d5740 Compare December 18, 2018 18:26
@modular-magician modular-magician merged commit 4f83529 into GoogleCloudPlatform:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants