[Terraform] fix disk behaivor in compute_instance_from_template #1077
+369
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#2122.
We use the instance expand code, which separates disks by type and merges them together into one list of disks. This meant that if a user tried to override an attached disk in the instance_from_template resource, it would try to override the boot disk as well. This fixes that bug, and also includes a fix where we were force-sending fields that weren't set, which meant that boolean fields that default to true and weren't overridden in the config were being overridden to false anyway.
[all]
[terraform]
fix disk behaivor in compute_instance_from_template
[terraform-beta]
[ansible]
[inspec]