Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code coverage stats as they aren't being consumed. #1075

Merged

Conversation

rileykarson
Copy link
Member

rake test will be able to be ran w/o side effects!


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

Copy link
Contributor

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make an issue to do some kind of code coverage (Coveralls?)?

Or at least make us have a conversation about what to do with code coverage in the future?

@rileykarson
Copy link
Member Author

Sure! We briefly discussed using coveralls in a meeting, so I'll add an issue for that.

@rileykarson
Copy link
Member Author

@modular-magician modular-magician merged commit 311076a into GoogleCloudPlatform:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants