AB

[ma-g-22]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: added `automated_backup_configuration` field to `google_bigtable_table` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 292 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 292 insertions(+), 1 deletion(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[trodge]

/gcbrun

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[ma-g-22]

/gcbrun

Thanks @trodge . I've updated the PR; could you take another look please?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 316 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 316 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table" "primary" {
  automated_backup_policy {
    frequency        = # value needed
    retention_period = # value needed
  }
}

[github-actions]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 278 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 278 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table" "primary" {
  automated_backup_policy {
    frequency        = # value needed
    retention_period = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 310 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 4 files changed, 310 insertions(+), 35 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table" "primary" {
  automated_backup_policy {
    frequency        = # value needed
    retention_period = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 328 insertions(+), 53 deletions(-))
google-beta provider: Diff ( 4 files changed, 328 insertions(+), 53 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_table (37 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_table" "primary" {
  automated_backup_policy {
    frequency        = # value needed
    retention_period = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3752
Passed tests: 3367
Skipped tests: 379
Affected tests: 6

Click here to see the affected service packages

all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccBigtableTable_automated_backups_enable

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test