-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade DCL to 1.66.0 #10564
Upgrade DCL to 1.66.0 #10564
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
cc current DCL build gardener: @rileykarson |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_clouddeploy_target" "primary" {
custom_target {
custom_target_type = # value needed
}
}
Resource: resource "google_compute_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_region_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud deploy tests passed in #10531, I'll try readding them OOB.
Firewall has no tests in DCL, but @c2thorn and @LucaPrete had discussed handling post-merge in cl/627113929. @c2thorn you'll ensure we get this tested by next release?
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Co-authored-by: Luca Prete <[email protected]>
Supersedes #10531
Release Note Template for Downstream PRs (will be copied)