Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to 1.66.0 #10564

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Apr 30, 2024

Supersedes #10531

Release Note Template for Downstream PRs (will be copied)

compute: added `security_profile_group`, `tls_inspect` to `google_compute_firewall_policy_rule`
compute: added `security_profile_group`, `tls_inspect` to `google_compute_network_firewall_policy_rule`
clouddeploy: added `custom_target` field to  `google_clouddeploy_target` resource
privateca: added `maximum_lifetime` field to  `google_privateca_certificate_template` resource

@github-actions github-actions bot requested a review from trodge April 30, 2024 19:44
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn
Copy link
Member

c2thorn commented Apr 30, 2024

cc current DCL build gardener: @rileykarson

@github-actions github-actions bot requested a review from rileykarson April 30, 2024 19:57
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 246 insertions(+), 49 deletions(-))
google-beta provider: Diff ( 18 files changed, 246 insertions(+), 49 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_target (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  custom_target {
    custom_target_type = # value needed
  }
}

Resource: google_compute_firewall_policy_rule (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_region_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3630
Passed tests: 3262
Skipped tests: 366
Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud deploy tests passed in #10531, I'll try readding them OOB.

Firewall has no tests in DCL, but @c2thorn and @LucaPrete had discussed handling post-merge in cl/627113929. @c2thorn you'll ensure we get this tested by next release?

@rileykarson rileykarson merged commit 0b5518b into GoogleCloudPlatform:main May 1, 2024
13 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants