Request review after PR author comments #10544
Conversation
melinath
requested review from
a team and
c2thorn
and removed request for
a team
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
|
||
| jobs: | ||
| request-review: | ||
| if: github.event.pull_request.draft == false | ||
| if: github.event.pull_request && github.event.pull_request.draft == false && (github.event.sender.login == github.event.pull_request.user.login || github.event.action != 'created') |
There was a problem hiding this comment.
just curious did we not need the null check github.event.pull_request && before?
There was a problem hiding this comment.
theoretically, this workflow would trigger for comments on issues (in which case github.event.issue would be populated instead). But issues are disabled on this repo so it shouldn't ever happen. But I figure it doesn't hurt to be explicit?
(Previously this wasn't a question because pull_request_target only triggers for pull requests.)
There was a problem hiding this comment.
I see, yep it doesn't hurt. Thanks for the explanation
go/terraform-pr-review-reminders
Note that this also makes it so that we request reviews for all PRs, regardless of target branch. I think that's okay since we're no longer tying review requests to test runs.
Release Note Template for Downstream PRs (will be copied)