Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate certificate template to mmv1 #10527

Merged

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Apr 24, 2024

Release Note Template for Downstream PRs (will be copied)

privateca: `google_privateca_certificate_template` now uses mmv1 engine instead of DCL

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch 2 times, most recently from 246f9f0 to 486bd10 Compare April 24, 2024 22:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_template (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_template (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_template (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3635
Passed tests: 3258
Skipped tests: 366
Affected tests: 11

Click here to see the affected service packages
all service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_withMaintenanceWindows|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3635
Passed tests: 3259
Skipped tests: 366
Affected tests: 10

Click here to see the affected service packages
all service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3635
Passed tests: 3258
Skipped tests: 366
Affected tests: 11

Click here to see the affected service packages
all service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_withMaintenanceWindows[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 486bd10 to 253ae9c Compare April 25, 2024 22:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2038 insertions(+), 1429 deletions(-))
google-beta provider: Diff ( 10 files changed, 2038 insertions(+), 1429 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_template (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3629
Passed tests: 3261
Skipped tests: 366
Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 253ae9c to b250cf7 Compare April 29, 2024 22:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2055 insertions(+), 1429 deletions(-))
google-beta provider: Diff ( 10 files changed, 2055 insertions(+), 1429 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privateca_certificate_template (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from b250cf7 to b158d15 Compare April 29, 2024 23:11
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3630
Passed tests: 3263
Skipped tests: 366
Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2057 insertions(+), 1429 deletions(-))
google-beta provider: Diff ( 10 files changed, 2057 insertions(+), 1429 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3630
Passed tests: 3261
Skipped tests: 366
Affected tests: 3

Click here to see the affected service packages
all service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccHealthcareDatasetIamPolicy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from b158d15 to 114c54a Compare April 30, 2024 18:33
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
google-beta provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3632
Passed tests: 3265
Skipped tests: 366
Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 114c54a to 426db92 Compare April 30, 2024 20:28
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
google-beta provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3632
Passed tests: 3265
Skipped tests: 366
Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the example that was used in the docs generation for the DCL resource so that we don't have a big diff in the docs page?

mmv1/products/privateca/CertificateTemplate.yaml Outdated Show resolved Hide resolved
@@ -35,8 +57,241 @@ examples:
primary_resource_id: 'default'
vars:
name: 'my-template'
parameters:
- !ruby/object:Api::Type::String
name: location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have changed the behavior (or at least documentation) of the IAM resource based on this.

Do you know what is going on there?

https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-10527-old..auto-pr-10527#diff-5dcfd60d59ef2ac2f119d71bdf3847bfc09604afa7e388e8abc050ebcc489bf0R140

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a bug for all mmv1 resources where the location field is documented as required on iam policy even though it is actually optional. I have fixed that in this PR.

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 72f9e92 to 05bdd9b Compare May 7, 2024 23:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 41 files changed, 2916 insertions(+), 1390 deletions(-))
google-beta provider: Diff ( 41 files changed, 2916 insertions(+), 1390 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3646
Passed tests: 3268
Skipped tests: 371
Affected tests: 7

Click here to see the affected service packages
all service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 05bdd9b to 24712ab Compare May 9, 2024 17:56
@trodge trodge force-pushed the privateca-certificate-template-mmv1 branch from 24712ab to 2cc6fdc Compare May 9, 2024 17:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 71 files changed, 3046 insertions(+), 1434 deletions(-))
google-beta provider: Diff ( 71 files changed, 3046 insertions(+), 1434 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 173 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 71 files changed, 3046 insertions(+), 1434 deletions(-))
google-beta provider: Diff ( 71 files changed, 3046 insertions(+), 1434 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 173 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3651
Passed tests: 3272
Skipped tests: 371
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3651
Passed tests: 3273
Skipped tests: 371
Affected tests: 7

Click here to see the affected service packages
all service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge requested a review from slevenick May 9, 2024 19:38
Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to override the breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/privateca
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants