Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding test for example_google_compute_network_endpoint_group r… #10523

Conversation

delimaneto
Copy link
Contributor

@delimaneto delimaneto commented Apr 24, 2024

Adding tests for resource asset type compute.googleapis.com/NetworkEndpointGroup which touchs the google terraform conversion.

Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from ScottSuarez April 24, 2024 18:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2024
@delimaneto
Copy link
Contributor Author

@ScottSuarez how can I fix the error for CLA ?

@ScottSuarez
Copy link
Contributor

I'm not quite sure, did you follow the instructions on the action?

https://github.com/GoogleCloudPlatform/magic-modules/pull/10523/checks?check_run_id=24216915986

@delimaneto
Copy link
Contributor Author

I'm not quite sure, did you follow the instructions on the action?

https://github.com/GoogleCloudPlatform/magic-modules/pull/10523/checks?check_run_id=24216915986

oh yeah, I had been followed this document, but I found how to fix that. Thanks!

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 25, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 85 insertions(+))

@ScottSuarez ScottSuarez merged commit 5d20188 into GoogleCloudPlatform:main Apr 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants