-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compute route tests #10521
add compute route tests #10521
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@zli82016 any tips related to this CLA error? I was wondering if this error should occur or not, because this is a public repository |
Hello, @kotarsky , can you open this link https://github.com/GoogleCloudPlatform/magic-modules/pull/10521/checks?check_run_id=24214839145? Even this is a public repository, Contributor License Agreement (CLA) is required to sign. |
@zli82016 I can open this link. |
Your commit is adding a test to tgc. Is it what you want to do? Or is there a Github issue for this PR? If yes, can you please add it to the description section of this PR? Thanks. |
There is no issue, it's just tests. But in this documentation it is saying that I should also include the tfplan.json file, but I couldn't find any file like that in the target folder, so I was wondering if the documentation is wrong or if I'm missing something. |
Sorry, the documentation is outdated. You don't need to include the _tfplan.json file. |
Created a Github issue to update the documentation. hashicorp/terraform-provider-google#17959 |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
add google_compute_route to resource_converters.go.erb file
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
adding new tests for compute.googleapis.com/Route