Add Go env vars to setup guide #10496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
melinath
approved these changes
Apr 19, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
May 8, 2024
pawelJas
pushed a commit
to pawelJas/magic-modules
that referenced
this pull request
May 16, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Cheriit
pushed a commit
to Cheriit/magic-modules
that referenced
this pull request
Jun 4, 2024
pcostell
pushed a commit
to pcostell/magic-modules
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://go.dev/doc/install never actually has you set a GOPATH env var, although we rely on it in our clone and generate commands. Using $GOPATH is technically an override for the default
GOPATHaccessible throughgo env GOPATH, but we can just explicitly set the default value here. The defaults~/gofor the most part, and anyone who did something different should be able to figure out where to deviate.Additionally, we expect
go installofgoimportsto work, but it doesn't by default. Users will eventually end up on a blog that instructs them to add GOPATH/bin to their PATH. Again, not covered by the default install commands.Release Note Template for Downstream PRs (will be copied)