Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude output only and parent fields from missing test detection #10473

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Apr 17, 2024

Parent fields are excluded because we check if the child fields are covered.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge requested a review from melinath April 17, 2024 19:29
@trodge trodge marked this pull request as ready for review April 17, 2024 19:29
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trodge trodge merged commit a9c3ca3 into GoogleCloudPlatform:main Apr 17, 2024
13 checks passed
@trodge trodge deleted the missing-tests branch April 17, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants