Add resource tags to BigQuery Table

[wj-chen]

Adds support for resource tags to BigQuery Table.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `resource_tags` field to `google_bigquery_table` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 143 insertions(+))

[modular-magician]

Tests analytics

Total tests: 115
Passed tests: 103
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryTable_ResourceTags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigQueryTable_ResourceTags[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

I verified the account has the appropriate permissions, so that error message is probably an effective 404 unless hierarchical permissions aren't getting respected here.

(I haven't taken a further look at the change itself yet)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 2 files changed, 216 insertions(+))

[wj-chen]

I verified the account has the appropriate permissions, so that error message is probably an effective 404 unless hierarchical permissions aren't getting respected here.

(I haven't taken a further look at the change itself yet)

Thank you for checking the permissions! It turned out to be a race condition where resources were referenced before creation, which should be fixed by the newest commit.

[modular-magician]

Tests analytics

Total tests: 115
Passed tests: 103
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryTable_ResourceTags

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_ResourceTags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rileykarson]

Generally LGTM- one question on the deletion precondition before approving/merging, and a couple nits inline.

[rileykarson]

Does the API have this check / does it take a long time to report a failure? Otherwise, if the API will reject the call there's not much value in doing this clientside first, since this will save 1s / one API call AIUI.

I'm a little hesitant about just checking state here- Terraform will sometimes short-circuit delete calls so Terraform may have drifted from the real config. I'm not sure we ever drift from state though, it's been a bit since I knew all the rules.

[wj-chen]

The deletion will go through actually, but what I discovered while debugging the VCR test failure is that if a table is deleted while having resource tags specified, it's impossible to delete the tag value resource, failing at "it's still has a binding". As a follow-up I'll reach out to our API team to discuss if the behavior should be fixed on the API-level.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 209 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 115
Passed tests: 104
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages

• bigquery

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[wj-chen]

Generally LGTM- one question on the deletion precondition before approving/merging, and a couple nits inline.

Thanks for the review! The new revision is out. Hoping to get this merged before the release cut today.