Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dns_record_set] change primary-backup -> failover in docs #10449

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

hkundag
Copy link
Contributor

@hkundag hkundag commented Apr 15, 2024

b/277747354

References to "Primary-Backup" in the dns_record_set documentation have been changed to "Failover".

Release Note Template for Downstream PRs (will be copied)

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (31 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 46
Passed tests: 45
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • dns

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

* `primary_backup` - (Optional) The configuration for a primary-backup policy with global to regional failover. Queries are responded to with the global primary targets, but if none of the primary targets are healthy, then we fallback to a regional failover policy.
Structure is [documented below](#nested_primary_backup).
* `primary_backup` - (Optional) The configuration for a failover policy with global to regional failover. Queries are responded to with the global primary targets, but if none of the primary targets are healthy, then we fallback to a regional failover policy.
Structure is [document below](#nested_primary_backup).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Structure is [document below](#nested_primary_backup).
Structure is [documented below](#nested_primary_backup).

I think this was correct originally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks for catching!

@github-actions github-actions bot requested a review from c2thorn April 17, 2024 17:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (31 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 46
Passed tests: 45
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • dns

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: I've removed the changelog note as documentation-only changes are not usually included.

@c2thorn c2thorn merged commit 5c9241e into GoogleCloudPlatform:main Apr 17, 2024
12 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants