Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom masking routine in google_bigquery_datapolicy_data_policy #10424

Closed
wants to merge 1 commit into from

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Apr 11, 2024

Fixes hashicorp/terraform-provider-google#17341.

Release Note Template for Downstream PRs (will be copied)

bigquery: added `routine` field to `google_bigquery_datapolicy_data_policy` resource

@github-actions github-actions bot requested a review from trodge April 11, 2024 21:49
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 268 insertions(+), 122 deletions(-))
google-beta provider: Diff ( 6 files changed, 268 insertions(+), 122 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 6 files changed, 159 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 103
Skipped tests: 11
Affected tests: 6

Click here to see the affected service packages
  • bigquery
  • bigquerydatapolicy

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyBasicExample[Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 268 insertions(+), 122 deletions(-))
google-beta provider: Diff ( 6 files changed, 268 insertions(+), 122 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 6 files changed, 159 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 105
Skipped tests: 11
Affected tests: 4

Click here to see the affected service packages
  • bigquery
  • bigquerydatapolicy

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 276 insertions(+), 122 deletions(-))
google-beta provider: Diff ( 6 files changed, 276 insertions(+), 122 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 6 files changed, 163 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 105
Skipped tests: 11
Affected tests: 4

Click here to see the affected service packages
  • bigquery
  • bigquerydatapolicy

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyWithCustomMaskingRoutineExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 281 insertions(+), 127 deletions(-))
google-beta provider: Diff ( 6 files changed, 281 insertions(+), 127 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 6 files changed, 163 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 106
Skipped tests: 11
Affected tests: 3

Click here to see the affected service packages
  • bigquery
  • bigquerydatapolicy

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDatapolicyDataPolicyIamBindingGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@sachinpro sachinpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@wj-chen
Copy link
Member Author

wj-chen commented Apr 18, 2024

Dupe of #10388

@wj-chen wj-chen closed this Apr 18, 2024
@wj-chen wj-chen deleted the 17341 branch April 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants