Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Terraform updates for instances with Google ML Integration enabled #10411

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rsm3171990
Copy link
Member

@rsm3171990 rsm3171990 commented Apr 10, 2024

This pull request addresses a bug where Terraform would fail to include the required database version when updating metadata for instances with the enable_google_ml_integration flag set to true. This resulted in API rejection of those update requests. Added acctest and verified that the change passes locally.

Fixes hashicorp/terraform-provider-google#17819

Release Note Template for Downstream PRs (will be copied)

sql: fixed issues with updating the `enable_google_ml_integration` field in `google_sql_database_instance` resource

@github-actions github-actions bot requested a review from NickElliot April 10, 2024 23:19
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 17 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 17 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 93
Passed tests: 77
Skipped tests: 14
Affected tests: 2

Click here to see the affected service packages
  • sql

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@rsm3171990
Copy link
Member Author

From the comment in an earlier PR:
It looks like the SQL user failure is known and probably unrelated: hashicorp/terraform-provider-google#16704

@NickElliot
Copy link
Contributor

/gcbrun

@NickElliot
Copy link
Contributor

rerunning to verify with test skipped

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 17 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 17 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 93
Passed tests: 78
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • sql

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickElliot NickElliot merged commit 2faba84 into GoogleCloudPlatform:main Apr 16, 2024
12 of 14 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform fails to include database version for Google ML-integrated instances, causing updates to be rejected
3 participants