Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Fix project services tests by using a service without any dependencies #1040

Conversation

rileykarson
Copy link
Member

We were broken in CI because the resource was authoritatively disabling services that turned off cloudbuild too. Fix that by using logging, which has no dependencies.

fyi @ndmckinley: not worth merging for 1.20.0 since it's test only, but fixes 2 test failures.


[all]

[terraform]

Fix project services tests by using a service without any dependencies

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#214
depends: hashicorp/terraform-provider-google#2645

@modular-magician modular-magician force-pushed the fix-project-services-tests branch from 75a3235 to 98c9e55 Compare December 12, 2018 19:14
@modular-magician modular-magician merged commit 8746274 into GoogleCloudPlatform:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants