Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that prevented setting 'create_ignore_already_exists' on existing resources #10394

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

chasevedder
Copy link
Member

@chasevedder chasevedder commented Apr 9, 2024

Currently if create_ignore_already_exists is the only field updated on a resource, the update will fail with "Error 400: Invalid field mask for ServiceAccount". Since this flag only controls Terraform behavior it should not trigger an update to the service account.

Release Note Template for Downstream PRs (will be copied)

iam: fixed a bug that prevented setting 'create_ignore_already_exists' on existing resources in `google_service_account`.

@github-actions github-actions bot requested a review from c2thorn April 9, 2024 18:04
Copy link

github-actions bot commented Apr 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 66 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 2 files changed, 66 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 137
Passed tests: 105
Skipped tests: 30
Affected tests: 2

Click here to see the affected service packages
  • resourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccServiceAccount_existingResourceCreateIgnoreAlreadyExists

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccServiceAccount_existingResourceCreateIgnoreAlreadyExists[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 60 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 60 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 137
Passed tests: 107
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn c2thorn merged commit a841407 into GoogleCloudPlatform:main Apr 15, 2024
11 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@chasevedder chasevedder deleted the create-ignore-fix branch May 28, 2024 22:59
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants