Better resourceref flexibility #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
force-pushed
the
better_resourceref_flexibility
branch
from
7d63833 to
e1eb5e0
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
rambleraptor
force-pushed
the
better_resourceref_flexibility
branch
from
7b84f14 to
afc3cd5
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit ffb03ab) have been included in your existing downstream PRs. |
SirGitsalot
approved these changes
Dec 14, 2018
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
better_resourceref_flexibility
branch
from
afc3cd5 to
6f5932c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceRefs on Ansible are the only MM downstream that follow the classical view of ResourceRefs. You build a dependency in a task, assign it to a variable (it's a dict) and then reference that variable in the resourceref field. The ResourceRef logic grabs the proper information from the dict.
This is less than ideal for users. Even with better documentation, it's just not intuitive enough for them. I've had multiple users mention this and using this system just makes the examples look opaque.
The new system allows users to input a dict (as before) or just a string of the proper value. The documentation mentions both of these systems.
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]