terraform Support for Managing Entitlements.

[varsharmavs]

`google_privileged_access_manager_entitlement` (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[varsharmavs]

Creation and Deletion of PAM Entitlement works. Updation is still in progress.

[NickElliot]

/gcbrun

[shuyama1]

@varsharmavs Sorry, there's an issue in our CI. Would you mind rebasing your PR to catch the latest fix? Thank you!

[varsharmavs]

It's 'pre_update' file which is added and not 'pre_delete'. sorry for the typo (commit: 97ef2a3)

[NickElliot]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 284 insertions(+))
google-beta provider: Diff ( 12 files changed, 1942 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 439 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privileged_access_manager_entitlement (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privileged_access_manager_entitlement" "primary" {
  additional_notification_targets {
    admin_email_recipients     = # value needed
    requester_email_recipients = # value needed
  }
  approval_workflow {
    manual_approvals {
      require_approver_justification = # value needed
      steps {
        approvals_needed          = # value needed
        approver_email_recipients = # value needed
        approvers {
          principals = # value needed
        }
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 284 insertions(+))
google-beta provider: Diff ( 12 files changed, 1942 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 439 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privileged_access_manager_entitlement (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privileged_access_manager_entitlement" "primary" {
  additional_notification_targets {
    admin_email_recipients     = # value needed
    requester_email_recipients = # value needed
  }
  approval_workflow {
    manual_approvals {
      require_approver_justification = # value needed
      steps {
        approvals_needed          = # value needed
        approver_email_recipients = # value needed
        approvers {
          principals = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3556
Passed tests: 3188
Skipped tests: 367
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3556
Passed tests: 3188
Skipped tests: 367
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3265
Skipped tests: 365
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3265
Skipped tests: 365
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3265
Skipped tests: 365
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 309 insertions(+))
google-beta provider: Diff ( 13 files changed, 2196 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 484 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 309 insertions(+))
google-beta provider: Diff ( 13 files changed, 2196 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 484 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_privileged_access_manager_entitlement (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privileged_access_manager_entitlement" "primary" {
  additional_notification_targets {
    admin_email_recipients     = # value needed
    requester_email_recipients = # value needed
  }
  approval_workflow {
    manual_approvals {
      require_approver_justification = # value needed
      steps {
        approvals_needed          = # value needed
        approver_email_recipients = # value needed
        approvers {
          principals = # value needed
        }
      }
    }
  }
  eligible_users {
    principals = # value needed
  }
  entitlement_id       = # value needed
  location             = # value needed
  max_request_duration = # value needed
  parent               = # value needed
  privileged_access {
    gcp_iam_access {
      resource      = # value needed
      resource_type = # value needed
      role_bindings {
        condition_expression = # value needed
        role                 = # value needed
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 309 insertions(+))
google-beta provider: Diff ( 13 files changed, 2196 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 484 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3266
Skipped tests: 365
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[NickElliot]

LGTM!

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3264
Skipped tests: 365
Affected tests: 2

Click here to see the affected service packages

all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3631
Passed tests: 3264
Skipped tests: 365
Affected tests: 2

Click here to see the affected service packages

all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test