Add protocol field for filestore Instance product

[DendoD96]

Fixes hashicorp/terraform-provider-google#17523. As NFSv4.1 is in preview, this feature is available only for google-beta provider.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

filestore: Added `protocol` property for `google_filestore_instance` instance to support NFSv3 and NFSv4.1

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[DendoD96]

Hi @rileykarson, can you take a look please?

Best regards,
Daniele

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 37 insertions(+))
google-beta provider: Diff ( 3 files changed, 113 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 0
Skipped tests: 0
Affected tests: 11

Click here to see the affected service packages

• filestore

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreBackup_filestoreBackupBasicExample|TestAccFilestoreBackup_update|TestAccFilestoreInstanceDatasource_basic|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreInstance_filestoreInstanceProtocolExample|TestAccFilestoreInstance_reservedIpRange_update|TestAccFilestoreInstance_restore|TestAccFilestoreInstance_update|TestAccFilestoreSnapshot_filestoreSnapshotBasicExample|TestAccFilestoreSnapshot_filestoreSnapshotFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFilestoreBackup_filestoreBackupBasicExample[Debug log]
TestAccFilestoreBackup_update[Debug log]
TestAccFilestoreInstanceDatasource_basic[Debug log]
TestAccFilestoreInstance_filestoreInstanceBasicExample[Debug log]
TestAccFilestoreInstance_filestoreInstanceFullExample[Debug log]
TestAccFilestoreInstance_filestoreInstanceProtocolExample[Debug log]
TestAccFilestoreInstance_reservedIpRange_update[Debug log]
TestAccFilestoreInstance_restore[Debug log]
TestAccFilestoreInstance_update[Debug log]
TestAccFilestoreSnapshot_filestoreSnapshotBasicExample[Debug log]
TestAccFilestoreSnapshot_filestoreSnapshotFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[DendoD96]

Hello @rileykarson,
terraform-google-conversion-build-and-unit-tests are broken, but I don't know how to fix (if I can).
Can you give me a suggestion?

Best regards,
Daniele

[rileykarson]

Ah- that's an overly-brittle test for an addon. You should just need to add an entry like "protocol": "NFS_V3" to https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/tgc/tests/data/example_filestore_instance.json

[DendoD96]

Thank you,
sorry for the oversight 😥

[rileykarson]

There are no materials in our docs covering that and no (reasonable) way to have caught that in local development, all good! I figure these out when I get a failure message too, ha. Really gotta fix the tight coupling between the provider and the TGC addon.

/gcbrun

[DendoD96]

Hi @rileykarson, just another question: why community-checker (graphite-docker-images) is in a waiting state?

[rileykarson]

I need to kick it, sorry about the delay. Thought there was an email before I had to do anything. Done that.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 37 insertions(+))
google-beta provider: Diff ( 3 files changed, 113 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 12 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 37 insertions(+))
google-beta provider: Diff ( 3 files changed, 117 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 12 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[rileykarson]

LGTM, thanks!