Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client request only properties. #10299

Merged

Conversation

rohitjangid
Copy link
Contributor

@rohitjangid rohitjangid commented Mar 27, 2024

Fix client request only properties to ignore read from api. Update examples to match actual usage.

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from SarahFrench March 27, 2024 05:47
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 128 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 12 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • integrations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIntegrationsClient_integrationsClientBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationsClient_integrationsClientBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohitjangid ! This PR looks ok to merge, but I wanted to check: is this fixing a user-facing issue?

I want to make sure the release note is accurate. If this PR just changes tests and internals of the resource in a way that's not noticeable to users I'd remove the release note. If there is a bug that's fixed by this PR I can update the release note to describe it

@rohitjangid
Copy link
Contributor Author

@SarahFrench This resource is not yet released in the latest terraform provide version. Since this is not being used by any users, there is no user impact.

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I've set the release note to none as I understand this isn't fixing a user-facing issue

@SarahFrench
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 128 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 128 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 105 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 12 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2
Passed tests: 1
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • integrations

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@SarahFrench SarahFrench merged commit 860ff25 into GoogleCloudPlatform:main Mar 28, 2024
15 checks passed
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants