-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client request only properties. #10299
Fix client request only properties. #10299
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
a504bbf
to
6349ad4
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsClient_integrationsClientBasicExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rohitjangid ! This PR looks ok to merge, but I wanted to check: is this fixing a user-facing issue?
I want to make sure the release note is accurate. If this PR just changes tests and internals of the resource in a way that's not noticeable to users I'd remove the release note. If there is a bug that's fixed by this PR I can update the release note to describe it
@SarahFrench This resource is not yet released in the latest terraform provide version. Since this is not being used by any users, there is no user impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I've set the release note to none
as I understand this isn't fixing a user-facing issue
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
Fix client request only properties to ignore read from api. Update examples to match actual usage.
Release Note Template for Downstream PRs (will be copied)