Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct google_firestore_backup_schedule recurrence descriptions #10295

Merged

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Mar 26, 2024

There was some inaccurate documentation for google_firestore_backup_schedule

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from hao-nan-li March 26, 2024 20:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@hao-nan-li
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@hao-nan-li hao-nan-li merged commit 5886ea4 into GoogleCloudPlatform:main Mar 26, 2024
14 checks passed
@rwhogg rwhogg deleted the fix-backup-schedule-docs branch April 2, 2024 17:23
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants