Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove FEATURE-branch-provider-functions project from TeamCity folder #10292

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Mar 26, 2024

This PR is meant to be merged once #10288 is merged into main.

This addresses the project that was added here #10088

Release Note Template for Downstream PRs (will be copied)


@SarahFrench SarahFrench self-requested a review March 26, 2024 17:21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 5 insertions(+), 106 deletions(-))

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the problems using TF 1.8.0 in TeamCity I think we're still ok to go ahead with removing these resources. If we want to test the provider-defined functions in TeamCity we can run custom builds with TF 1.8.0.

@BBBmau BBBmau merged commit 7c76bbc into GoogleCloudPlatform:main Mar 28, 2024
11 checks passed
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants