-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cron triggers defined in .teamcity
to use branches that aren't main
#10270
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
@BBBmau if you pull main into your branch the acceptance tests should be able to run as expected! |
0110f54
to
ab6d133
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared some errors from the automated TeamCity config tests - now the dependency issue is fixed you can use the .teamcity/Makefile tools to check if the code build ok or not.
mmv1/third_party/terraform/.teamcity/components/builds/build_triggers.kt
Show resolved
Hide resolved
mmv1/third_party/terraform/.teamcity/components/builds/build_triggers.kt
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/.teamcity/tests/nightly_tests_project.kt
Outdated
Show resolved
Hide resolved
Tests are now passing after running
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Send me a DM when you merge this and we can check it as TeamCity loads in the new config
Gives users the ability to run tests that aren't main by being able to provide their own branch name. default would be
ref/head/main
This PR also insures that nightly tests are ran on
main
by adding an assertion to check that thebranchFilter
is in fact+:ref/head/main
Release Note Template for Downstream PRs (will be copied)