Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tpuIpv4CidrBlock for container clusters #1020

Merged
merged 5 commits into from
Dec 11, 2018

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Dec 10, 2018


[all]

Add tpuIpv4CidrBlock for container clusters

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#201
depends: modular-magician/ansible#148

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add TF docs?

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 5213212) have been included in your existing downstream PRs.

@chrisst
Copy link
Contributor Author

chrisst commented Dec 11, 2018

Added more things to api.yaml which are effectively a no-op but should allow ansible to get tpu support once it comes out of beta.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit edc3610) have been included in your existing downstream PRs.

@modular-magician modular-magician merged commit a02063a into GoogleCloudPlatform:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants