Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Add docs about using lifecycle when recreating instance groups #1018

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Dec 10, 2018

Fixes hashicorp/terraform-provider-google#1853

Users can avoid the error with lifecycle.create_before_destroy; it isn't feasible to copy the Disk behaviour because an InstanceGroup doesn't list its users. We would need to list every BackendService / other users (are there any?) in the zone and GET each of them for a similar approach to be feasible.


[all]

[terraform]

Add docs about using lifecycle when recreating instance groups

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#200
depends: hashicorp/terraform-provider-google#2620

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Riley!

Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit a5e7a5c into GoogleCloudPlatform:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants