Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type field to DNS authorization reosurce #10030

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Add type field to DNS authorization reosurce #10030

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8e88bb
Add type field to DNS authorization reosurce
Feb 23, 2024
59accc4
Add an example for regional DNS authorization
Feb 23, 2024
dfc1a68
Add an example for regional certs using regional DNS auth
Feb 23, 2024
a9320ac
Fix lint errors
Feb 26, 2024
f5e6cd9
Fix typo in the enum values
Feb 27, 2024
3a538e3
Add type field in regional dns auth example
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmv1/products/certificatemanager/DnsAuthorization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ properties:
immutable: true
values:
- :FIXED_RECORD
- :PER_RPOJECT_REOCRD
- :PER_PROJECT_RECORD
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like when an ENUM field is marked with default_from_api, TF accepts whatever value that comes from the API without checking if this value is a valid ENUM value. It looks to me as a bug in TF side.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily, since we know that the type value will be returned as any of the values listed, being either FIXED_RECORD or PER_PROJECT_RECORD

default_from_api: true
- !ruby/object:Api::Type::NestedObject
name: 'dnsResourceRecord'
Expand Down