-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type field to DNS authorization reosurce #10030
Merged
BBBmau
merged 6 commits into
GoogleCloudPlatform:main
from
Hamzawy63:dns-authorization-type-field-addition
Mar 1, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b8e88bb
Add type field to DNS authorization reosurce
59accc4
Add an example for regional DNS authorization
dfc1a68
Add an example for regional certs using regional DNS auth
a9320ac
Fix lint errors
f5e6cd9
Fix typo in the enum values
3a538e3
Add type field in regional dns auth example
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
mmv1/templates/terraform/examples/certificate_manager_dns_authorization_regional.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
resource "google_certificate_manager_dns_authorization" "<%= ctx[:primary_resource_id] %>" { | ||
name = "<%= ctx[:vars]['dns_auth_name'] %>" | ||
location = "us-central1" | ||
description = "reginal dns" | ||
type = "PER_PROJECT_RECORD" | ||
domain = "<%= ctx[:vars]['subdomain'] %>.hashicorptest.com" | ||
} |
19 changes: 19 additions & 0 deletions
19
...erraform/examples/certificate_manager_google_managed_regional_certificate_dns_auth.tf.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
resource "google_certificate_manager_certificate" "<%= ctx[:primary_resource_id] %>" { | ||
name = "<%= ctx[:vars]['cert_name'] %>" | ||
description = "regional managed certs" | ||
location = "us-central1" | ||
managed { | ||
domains = [ | ||
google_certificate_manager_dns_authorization.instance.domain, | ||
] | ||
dns_authorizations = [ | ||
google_certificate_manager_dns_authorization.instance.id, | ||
] | ||
} | ||
} | ||
resource "google_certificate_manager_dns_authorization" "instance" { | ||
name = "<%= ctx[:vars]['dns_auth_name'] %>" | ||
location = "us-central1" | ||
description = "The default dnss" | ||
domain = "<%= ctx[:vars]['dns_auth_subdomain'] %>.hashicorptest.com" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like when an ENUM field is marked with default_from_api, TF accepts whatever value that comes from the API without checking if this value is a valid ENUM value. It looks to me as a bug in TF side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessarily, since we know that the
type
value will be returned as any of the values listed, being eitherFIXED_RECORD
orPER_PROJECT_RECORD