Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Remove update_strategy from rigm. #1002

Merged
merged 2 commits into from
Dec 10, 2018
Merged

[Terraform]: Remove update_strategy from rigm. #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
defeab5
Remove update_strategy from rigm.
rileykarson Dec 6, 2018
9d0c291
Update tracked submodules -> HEAD on Mon Dec 10 16:27:11 UTC 2018
modular-magician Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/inspec
Open in desktop
Submodule inspec updated 1 files
+2 −2 libraries/gcp_backend.rb
2 changes: 1 addition & 1 deletion build/terraform
Open in desktop
Submodule terraform updated from 7f932b to f1676a
2 changes: 1 addition & 1 deletion build/terraform-beta
Open in desktop
Submodule terraform-beta updated from 4f70ab to abf8b0
3 changes: 1 addition & 2 deletions third_party/terraform/resources/resource_compute_region_instance_group_manager.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,9 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource {
<% if version.nil? || version == 'ga' -%>
"update_strategy": &schema.Schema{
Type: schema.TypeString,
Deprecated: "This field is deprecated as it has no functionality anymore. It will be removed in 3.0.0.",
Deprecated: "This field is removed.",
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{"NONE", "ROLLING_UPDATE"}, false),
},
<% end -%>

Expand Down
2 changes: 0 additions & 2 deletions third_party/terraform/tests/resource_compute_region_instance_group_manager_test.go.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ func TestAccRegionInstanceGroupManager_updateStrategy(t *testing.T) {
ResourceName: "google_compute_region_instance_group_manager.igm-update-strategy",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"update_strategy"},
},
},
})
Expand Down Expand Up @@ -998,7 +997,6 @@ resource "google_compute_region_instance_group_manager" "igm-update-strategy" {
base_instance_name = "rigm-update-strategy"
region = "us-central1"
target_size = 2
update_strategy = "NONE"
named_port {
name = "customhttp"
port = 8080
Expand Down
3 changes: 0 additions & 3 deletions ...ty/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ The following arguments are supported:
* `project` - (Optional) The ID of the project in which the resource belongs. If it
is not provided, the provider project is used.

* `update_strategy` - (Optional, Default `"NONE"`) This field is deprecated as it has no functionality anymore.
It previously turned update behaviour on and off. This field is only present in the `google` provider.

* `target_size` - (Optional) The target number of running instances for this managed
instance group. This value should always be explicitly set unless this resource is attached to
an autoscaler, in which case it should never be set. Defaults to `0`.
Expand Down