Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook instances output tags by default #10006

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Feb 16, 2024

fixes hashicorp/terraform-provider-google#17075

Release Note Template for Downstream PRs (will be copied)

notebooks: changed `tag` field to default to the API's value if not specified in `google_notebooks_instance` 

@github-actions github-actions bot requested a review from c2thorn February 16, 2024 23:20
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn
Copy link
Member

c2thorn commented Feb 20, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 24
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • notebooks

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@github-actions github-actions bot requested a review from c2thorn February 20, 2024 17:12
@c2thorn c2thorn merged commit 41f37f5 into GoogleCloudPlatform:main Feb 20, 2024
18 checks passed
@bcreddy-gcp bcreddy-gcp deleted the notebook_tags branch February 20, 2024 18:22
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Feb 29, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 6, 2024
Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Mar 11, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_notebooks_instance don't persist tags in state
3 participants