Skip to content

Commit

Permalink
cloudbuild build trigger's trigger template should be required in 3.0…
Browse files Browse the repository at this point in the history
….0. (#2352)

* cloudbuild build trigger's trigger template should be required in 3.0.0.
nat-henderson authored and rileykarson committed Nov 13, 2019
1 parent 50769bc commit eb90d28
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions products/cloudbuild/api.yaml
Original file line number Diff line number Diff line change
@@ -113,6 +113,7 @@ objects:
Branch and tag names in trigger templates are interpreted as regular
expressions. Any branch or tag change that matches that regular
expression will trigger a build.
required: true
properties:
- !ruby/object:Api::Type::String
name: 'projectId'
3 changes: 0 additions & 3 deletions products/cloudbuild/terraform.yaml
Original file line number Diff line number Diff line change
@@ -30,9 +30,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
default_from_api: true
build.steps: !ruby/object:Overrides::Terraform::PropertyOverride
name: 'step'
triggerTemplate: !ruby/object:Overrides::Terraform::PropertyOverride
description: |
{{description}}This field is required, and will be validated as such in 3.0.0.
triggerTemplate.projectId: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
custom_code: !ruby/object:Provider::Terraform::CustomCode

0 comments on commit eb90d28

Please sign in to comment.